Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: weighted random spawns #1848

Merged
merged 5 commits into from
Dec 9, 2023
Merged

feat: weighted random spawns #1848

merged 5 commits into from
Dec 9, 2023

Conversation

luan
Copy link
Contributor

@luan luan commented Nov 20, 2023

Rework of #1802 to fix issues with boss spawns and adding a "weight" to enable users to balance things.

Credits to @Schiffers for the original PR and idea.

@Schiffers
Copy link
Contributor

Fiz alguns testes e tive alguns retornos
Ai te pergunto, qual o comportamento "esperado"?
Não há variação dos monstros em si
A variação que tem é que nem todos os monstros do mesmo Spawn são spawnados
Não há a troca de um monstro pelo outro 🤔🤔🤔

@luan luan force-pushed the luan/random-spawn branch from 58866d7 to 21146cf Compare November 23, 2023 18:27
@luan
Copy link
Contributor Author

luan commented Nov 23, 2023

Fiz alguns testes e tive alguns retornos Ai te pergunto, qual o comportamento "esperado"? Não há variação dos monstros em si A variação que tem é que nem todos os monstros do mesmo Spawn são spawnados Não há a troca de um monstro pelo outro 🤔🤔🤔

Arrumei uns bugs ali mas aqui ta funcionando o random sim, os bugs eram com o timer do spawn

@Mirkaanks
Copy link
Contributor

Mirkaanks commented Nov 28, 2023 •
edited
Loading

Seria bom adicionar uma opção no spawn que configura-se o random spawn.

image

@luan luan force-pushed the luan/random-spawn branch from 21146cf to 036669a Compare December 2, 2023 06:13
@luanluciano93
Copy link
Contributor

luanluciano93 commented Dec 2, 2023 •
edited
Loading

Seria bom adicionar uma opção no spawn que configura-se o random spawn.

image

Melhor ainda seria colocar a opção de random no spawn:
<monster centerx="1" centery="1" centerz="1" radius="1" randomSpawn = true >

Schiffers
Schiffers approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Schiffers Schiffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realmente randomiza os monstros, não saberia como fazer um teste mais pesado de como funciona, mas afinal, randomiza os monstros e atente os requisitos de intervalo

@luan luan force-pushed the luan/random-spawn branch from 036669a to e852015 Compare December 9, 2023 22:12
@luan luan merged commit c778b8e into main Dec 9, 2023
37 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@majestyotbr majestyotbr deleted the luan/random-spawn branch December 21, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beats-dh beats-dh beats-dh approved these changes

@Schiffers Schiffers Schiffers approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luan @Schiffers @Mirkaanks @luanluciano93 @beats-dh