Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: "/i" create a big count of stackable items #1863

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

dudantas
Copy link
Member

/i silver token, 7000

@dudantas dudantas changed the title improve: create a big count of stackable items improve: "/i" create a big count of stackable items Nov 21, 2023
@dudantas dudantas merged commit 6fde259 into main Nov 21, 2023
18 checks passed
@dudantas dudantas deleted the improve-create-stackable-item-big-count branch November 21, 2023 15:02
@macvirii
Copy link
Contributor

This code throws the stack in the ground (or at least for me it's throwing on the ground below the character)
But only on stackable items, Idk if it's because is using Game.createItem instead of player:addItem

@dudantas
Copy link
Member Author

dudantas commented Nov 24, 2023

This code throws the stack in the ground (or at least for me it's throwing on the ground below the character) But only on stackable items, Idk if it's because is using Game.createItem instead of player:addItem

Like this? I only edited it for stackable items.
This way, we can create a huge amount of groupable items at once, for testing purposes, of course. Obviously you need to have a free container to create, otherwise it will fall to the ground.

I only use Game.createItem to create all amounts at once, and player:addItemEx to add them to the player, as this avoids overloading the server.

@macvirii
Copy link
Contributor

Even with a free container it's falling to the ground

@dudantas
Copy link
Member Author

Even with a free container it's falling to the ground

I tested this, it doesn't fall to the floor. The player:addItemEx adds the items to the player.

@macvirii
Copy link
Contributor

image

This is really strange

@macvirii
Copy link
Contributor

this with /i ultimate healing rune,10

@dudantas
Copy link
Member Author

image

This is really strange

Okay, I'll test it.

@macvirii
Copy link
Contributor

I git pulled like 2-3 hours and compiled, so it's the most recent code.
Before it worked for stackable items fine... creating runes worked.
Now you can create a large quantity of the other items (and it goes on the backpack) but the runes don`t.
That's what I could research for now.

@dudantas
Copy link
Member Author

dudantas commented Nov 24, 2023

I git pulled like 2-3 hours and compiled, so it's the most recent code. Before it worked for stackable items fine... creating runes worked. Now you can create a large quantity of the other items (and it goes on the backpack) but the runes don`t. That's what I could research for now.

Ok, thanks for reporting... Test this please: #1898 (you can comment on the new pr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants