fix: change creature from checkCreatures from reference to copy #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
realmente, esse PR de acordo com meus testes fez alguma diferença, as vezes estava tendo crashs aleatórios somente ao abrir o canary-sln, ja corria matar algum bicho pra testar quest e já dava crash, agora não está dando crash (além claro dos que eu mesmo bugo o ot com restart) |
Schiffers
approved these changes
Nov 27, 2023
luan
approved these changes
Nov 27, 2023
majestyotbr
approved these changes
Nov 27, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the Creature's shared_ptr is handled properly and prevents a crash from occurring due to the creature being prematurely removed.
Resolves #1896