Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: critical damage and message log #1909

Closed
wants to merge 1 commit into from

Conversation

Schiffers
Copy link
Contributor

@Schiffers Schiffers commented Nov 25, 2023

Fix Critical hit multiplier and server log message

resolves #1893
resolves #1888

please test it

Test Configuration:

  • Server Version: canary 13.21
  • Client: 13.21
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@dudantas dudantas changed the title fix: critical damage & message log fix: critical damage and message log Nov 25, 2023
@dudantas
Copy link
Member

We are closing this pull request in favor of the changes proposed in #1913. We appreciate your efforts and contributions. Thank you for being a part of this project.

@dudantas dudantas closed this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical Hit Log Issue Critial Hit
3 participants