improve: adjustment in global functions #1917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luanluciano93
commented
Nov 26, 2023
luanluciano93
commented
- global variables from the save_interval file are transferred to the file and become local variables.
- table.contains and addStamina functions sent to libs/functions/functions.lua.
- table FAMILIARSNAME is not used anywhere, so it was removed.
elsongabriel
changed the title
elsongabriel
changed the title
dudantas
reviewed
Nov 27, 2023
| @@ -1,3 +1,14 @@ | |||
| local SAVE_INTERVAL_TYPE = configManager.getString(configKeys.SAVE_INTERVAL_TYPE) | |||
There was a problem hiding this comment.
I don't see why moving this to the scripts if it's something shared... And you broke the naming convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.