fix: lua getNumber overflow #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beats-dh
approved these changes
Nov 30, 2023
majestyotbr
approved these changes
Nov 30, 2023
luan
approved these changes
Nov 30, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting Lua numbers to unsigned integer types in C++ can be problematic due to Lua's lua_tonumber function defaulting to -1 when no explicit integer is defined. This poses an overflow risk when casting to unsigned types like uint32_t or uint16_t in C++, as negative values translate to large positive numbers.
This pull request addresses the issue by implementing a check in the Lua-to-C++ conversion function. If lua_tonumber returns a negative value, we adjust the value to 0 for unsigned types. This ensures safe and accurate conversion of Lua values to C++ unsigned integers, avoiding unexpected overflow and maintaining data integrity.