docs: change server release version to 3.1.2 and set debug log #1954
reviewdog [cppcheck] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (160)
src/canary_server.cpp|| Too many #ifdef configurations - cppcheck only checks 12 of 24 configurations. Use --force to check all configurations.
src/creatures/creatures_definitions.hpp|1661| Variable 'itemName' is assigned in constructor body. Consider performing initialization in initialization list.
src/security/rsa.hpp|16| Class 'RSA' has a constructor with 1 argument that is not explicit.
src/canary_server.cpp|319| Same expression on both sides of '||' because 'datapackName!="data-canary"&&datapackName!="data-otservbr-global"' and 'datapackName!="data-otservbr-global"&&datapackName!="data-canary"' represent the same value.
src/creatures/creatures_definitions.hpp|1545| Function parameter 'initName' should be passed by const reference.
src/creatures/creatures_definitions.hpp|1545| Function parameter 'initType' should be passed by const reference.
src/game/game.hpp|362| Function parameter 'itemIds' should be passed by const reference.
src/game/scheduling/task.hpp|16| Function parameter 'context' should be passed by const reference.
src/game/scheduling/task.hpp|21| Function parameter 'context' should be passed by const reference.
src/game/scheduling/dispatcher.hpp|101| Function parameter 'context' should be passed by const reference.
src/game/scheduling/dispatcher.hpp|106| Function parameter 'context' should be passed by const reference.
src/server/network/webhook/webhook.hpp|33| Function parameter 'payload' should be passed by const reference.
src/server/network/webhook/webhook.hpp|34| Function parameter 'title' should be passed by const reference.
src/server/network/webhook/webhook.hpp|34| Function parameter 'message' should be passed by const reference.
src/server/network/webhook/webhook.hpp|46| Function parameter 'title' should be passed by const reference.
src/server/network/webhook/webhook.hpp|46| Function parameter 'message' should be passed by const reference.
src/game/zones/zone.hpp|205| Unused variable: _
src/canary_server.cpp|200| Skipping configuration 'LUAJIT_VERSION' since the value of 'LUAJIT_VERSION' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
src/canary_server.cpp|253| Skipping configuration 'NDEBUG;_MSC_VER;_WIN32' since the value of '_MSC_VER' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
src/canary_server.cpp|253| Skipping configuration '_MSC_VER' since the value of '_MSC_VER' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
src/canary_server.cpp|253| Skipping configuration '_MSC_VER;_WIN32' since the value of '_MSC_VER' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
src/creatures/appearance/outfit/outfit.cpp|72| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/combat/combat.cpp|1467| Identical inner 'if' condition is always true.
src/creatures/combat/combat.cpp|34| Variable 'magicLevelSkill' is assigned a value that is never used.
src/creatures/combat/combat.cpp|1357| Variable 'pos' is not assigned a value.
src/creatures/combat/condition.cpp|1733| Consider using std::accumulate algorithm instead of a raw loop.
src/creatures/creature.cpp|1377| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/creature.cpp|1386| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/creature.cpp|1511| Consider using std::any_of algorithm instead of a raw loop.
src/creatures/interactions/chat.cpp|480| The statement 'if (type!=TALKTYPE_CHANNEL_Y) type=TALKTYPE_CHANNEL_Y' is logically equivalent to 'type=TALKTYPE_CHANNEL_Y'.
src/creatures/monsters/monster.cpp|855| Consider using std::any_of algorithm instead of a raw loop.
src/creatures/monsters/monster.cpp|986| Consider using std::count_if algorithm instead of a raw loop.
src/creatures/monsters/monster.cpp|1055| Variable 'x' is not assigned a value.
src/creatures/monsters/monsters.cpp|257| Condition '!combatSpell' is always false
src/creatures/monsters/monsters.cpp|265| Condition 'combatSpell' is always true
src/creatures/monsters/spawns/spawn_monster.cpp|273| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/npcs/npc.cpp|267| Consider using std::accumulate algorithm instead of a raw loop.
src/creatures/npcs/npc.cpp|376| Consider using std::accumulate algorithm instead of a raw loop.
src/creatures/players/grouping/familiars.cpp|66| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/players/grouping/groups.cpp|104| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/players/grouping/guild.cpp|37| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/players/grouping/guild.cpp|46| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/players/grouping/guild.cpp|55| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/players/grouping/party.cpp|476| Variable 'highestLevel' is assigned a value that is never used.
src/creatures/players/grouping/party.cpp|751| Variable '(*it).second' is assigned a value that is never used.
src/creatures/players/grouping/party.cpp|778| Variable '(*it).second' is assigned a value that is never used.
src/creatures/players/imbuements/imbuements.cpp|342| Unused variable: key
src/creatures/players/player.cpp|366| Redundant condition: shield. '!A || (A && B)' is equivalent to '!A || B'
src/creatures/players/player.cpp|395| Condition 'weapon' is always false
src/creatures/players/player.cpp|400| Condition 'shield' is always false
src/creatures/players/player.cpp|401| Condition 'weapon!=nullptr' is always false
src/creatures/players/player.cpp|2708| The scope of the variable 'maxBlessing' can be reduced.
src/creatures/players/player.cpp|7657| The scope of the variable 'stage' can be reduced.
src/creatures/players/player.cpp|830| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/players/player.cpp|1854| Consider using std::any_of algorithm instead of a raw loop.
src/creatures/players/player.cpp|4580| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/players/player.cpp|4805| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/players/player.cpp|4826| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/players/player.cpp|4880| Consider using std::any_of algorithm instead of a raw loop.
src/creatures/players/player.cpp|4889| Consider using std::any_of algorithm instead of a raw loop.
src/creatures/players/player.cpp|7584| Consider using std::accumulate algorithm instead of a raw loop.
src/creatures/players/player.cpp|7643| Consider using std::accumulate algorithm instead of a raw loop.
src/creatures/players/player.cpp|619| Unused variable: key
src/creatures/players/player.cpp|2837| Unused variable: key
src/creatures/players/player.cpp|2891| Unused variable: key
src/creatures/players/player.cpp|2897| Unused variable: key
src/creatures/players/player.cpp|6953| Variable 'mapTier' is not assigned a value.
src/creatures/players/player.cpp|7026| Variable 'mapTier' is not assigned a value.
src/creatures/players/player.cpp|7149| Variable 'mapTier' is not assigned a value.
src/creatures/players/player.cpp|7597| Variable 'stage' is assigned a value that is never used.
src/creatures/players/vocations/vocation.cpp|204| Consider using std::find_if algorithm instead of a raw loop.
src/creatures/players/wheel/player_wheel.cpp|1687| The scope of the variable 'magicSkill' can be reduced.
src/creatures/players/wheel/player_wheel.cpp|1688| The scope of the variable 'distanceSkill' can be reduced.
src/creatures/players/wheel/player_wheel.cpp|1716| The scope of the variable 'newCritical' can be reduced.
src/creatures/players/wheel/player_wheel.cpp|74| struct member 'PromotionScroll::itemId' is never used.
src/creatures/players/wheel/player_wheel.cpp|76| struct member 'PromotionScroll::extraPoints' is never used.
src/creatures/players/wheel/player_wheel.cpp|2478| Variable 'name_it' is not assigned a value.
src/game/scheduling/events_scheduler.cpp|90| Local variable 'eventName' shadows outer variable
src/game/scheduling/save_manager.cpp|19| Unused variable: _
src/game/scheduling/save_manager.cpp|25| Unused variable: _
src/game/zones/zone.cpp|97| Consider using std::copy algorithm instead of a raw loop.
src/game/zones/zone.cpp|141| Unused variable: _
src/game/zones/zone.cpp|149| Unused variable: _
src/game/zones/zone.cpp|157| Unused variable: _
src/game/zones/zone.cpp|172| Unused variable: _
src/io/functions/iologindata_load_player.cpp|838| Unused variable: id
src/io/functions/iologindata_save_player.cpp|38| Condition '!container' is always false
src/io/functions/iologindata_save_player.cpp|329| Variable 'itemId' is not assigned a value.
src/io/functions/iologindata_save_player.cpp|781| Variable 'key' is not assigned a value.
src/io/io_bosstiary.cpp|288| Consider using std::count_if algorithm instead of a raw loop.
src/io/io_bosstiary.cpp|76| Variable 'randomBossId' is not assigned a value.
src/io/io_bosstiary.cpp|156| Variable 'bossRaceId' is not assigned a value.
src/io/iobestiary.cpp|100| Consider using std::find_if algorithm instead of a raw loop.
src/io/iomap.cpp|125| The scope of the variable 'tileIsStatic' can be reduced.
src/io/iomapserialize.cpp|78| Unused variable: key
src/io/iomapserialize.cpp|326| Unused variable: key
src/io/iomapserialize.cpp|342| Unused variable: key
src/items/functions/item/attribute.cpp|50| Consider using std::find_if algorithm instead of a raw loop.
src/items/functions/item/item_parse.cpp|716| Condition 'conditionDamage' is always false
src/items/functions/item/item_parse.cpp|551| Consider using std::transform algorithm instead of a raw loop.
src/items/item.cpp|2843| Condition 'subType!=1' is always true
src/items/item.cpp|1013| The scope of the variable 'isTradeable' can be reduced.
src/items/tile.cpp|1791| Condition 'items' is always true
src/kv/value_wrapper.cpp|39| Unused variable: _
src/lua/creature/creatureevent.cpp|17| Unused variable: name
src/lua/creature/movement.cpp|135| Consider using std::any_of algorithm instead of a raw loop.
src/lua/functions/core/game/game_functions.cpp|41| Condition '!monsterType' is always false
src/lua/functions/core/game/game_functions.cpp|66| Local variable 'alternateName' shadows outer variable
src/lua/functions/creatures/combat/spell_functions.cpp|617| Either the condition 'vocList.size()>0' is redundant or vocList size can be 1. Expression 'vocList[1]' cause access out of bounds.
src/lua/functions/creatures/creature_functions.cpp|508| Expression is always true because 'else if' condition is opposite to previous condition at line 506.
src/lua/functions/creatures/creature_functions.cpp|784| Condition 'oldPosition.x<position.x' is always true
src/lua/functions/creatures/monster/monster_type_functions.cpp|1008| Unused variable: _
src/lua/functions/creatures/npc/npc_functions.cpp|563| The scope of the variable 'shoppingBagSlots' can be reduced.
src/lua/functions/creatures/npc/npc_functions.cpp|582| Consider using std::find_if algorithm instead of a raw loop.
src/lua/functions/creatures/npc/npc_functions.cpp|588| Unused variable: _
src/lua/functions/creatures/player/player_functions.cpp|332| Consider using std::any_of algorithm instead of a raw loop.
src/lua/functions/creatures/player/player_functions.cpp|3052| Unused variable: key
src/lua/functions/items/item_functions.cpp|721| Condition 'moveItem' is always false
src/lua/scripts/script_environment.cpp|77| Consider using std::find_if algorithm instead of a raw loop.
src/main.cpp|| Too many #ifdef configurations - cppcheck only checks 12 of 16 configurations. Use --force to check all configurations.
src/map/house/house.cpp|524| Local variable 'line' shadows outer variable
src/map/house/house.cpp|685| Consider using std::find_if algorithm instead of a raw loop.
src/map/map.cpp|705| Consider using std::copy_if algorithm instead of a raw loop.
src/protobuf/appearances.pb.cc|| This file is not analyzed. Cppcheck failed to extract a valid configuration. Use -v for more details.
src/protobuf/kv.pb.cc|| This file is not analyzed. Cppcheck failed to extract a valid configuration. Use -v for more details.
src/security/rsa.cpp|164| The scope of the variable 'buffer' can be reduced.
src/server/network/protocol/protocolgame.cpp|345| Condition 'containerType==0' is always true
src/server/network/protocol/protocolgame.cpp|3050| Condition 'counter>0' is always true
src/server/network/protocol/protocolgame.cpp|57| Consider using std::distance algorithm instead of a raw loop.
src/server/network/protocol/protocolgame.cpp|349| Consider using std::accumulate algorithm instead of a raw loop.
src/server/network/protocol/protocolgame.cpp|2844| Unused variable: ss
src/server/network/protocol/protocolgame.cpp|3970| Variable 'flag' is assigned a value that is never used.
src/server/network/protocol/protocolgame.cpp|3978| Variable 'flag' is assigned a value that is never used.
src/server/network/protocol/protocolgame.cpp|4969| Variable 'iteratorItemId' is not assigned a value.
src/server/network/protocol/protocolgame.cpp|7045| Variable 'masterPlayer' is assigned a value that is never used.
src/server/network/protocol/protocolgame.cpp|7942| Variable 'itemTier' is not assigned a value.
src/server/network/protocol/protocolstatus.cpp|100| Unused variable: key
src/utils/tools.cpp|1618| Condition 'number>=7400' is always true
src/utils/tools.cpp|483| Function parameter 'string' should be passed by const reference.
src/utils/tools.cpp|193| Consider using std::accumulate algorithm instead of a raw loop.
src/utils/tools.cpp|387| Consider using std::transform algorithm instead of a raw loop.
src/utils/tools.cpp|1026| Consider using std::find_if algorithm instead of a raw loop.
src/utils/tools.cpp|415| Variable 'a' is not assigned a value.
src/utils/tools.cpp|453| The function 'formatTime' is never used.
src/utils/tools.cpp|198| The function 'generateToken' is never used.
src/utils/tools.cpp|1551| The function 'getObjectCategoryName' is never used.
src/utils/tools.cpp|1677| The function 'getPlayerObjectPronoun' is never used.
src/utils/tools.cpp|1694| The function 'getPlayerPossessivePronoun' is never used.
src/utils/tools.cpp|1711| The function 'getPlayerReflexivePronoun' is never used.
src/utils/tools.cpp|1660| The function 'getPlayerSubjectPronoun' is never used.
src/utils/tools.cpp|919| The function 'getSkullType' is never used.
src/utils/tools.cpp|939| The function 'getSpawnType' is never used.
src/utils/tools.cpp|1728| The function 'getVerbForPronoun' is never used.
src/utils/tools.cpp|911| The function 'getWeaponAction' is never used.
src/utils/pugicast.cpp|13| The function 'logError' is never used.
src/utils/tools.cpp|283| The function 'toCamelCase' is never used.
src/utils/tools.cpp|339| The function 'toKebabCase' is never used.
src/utils/tools.cpp|323| The function 'toSnakeCase' is never used.
src/utils/tools.cpp|1518| The function 'validateName' is never used.
nofile|| Cppcheck cannot find all the include files (use --check-config for details)