Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sound for open and close doors #1978

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Dec 5, 2023

changes:

  • Added open sound to custom/normal doors
  • Added open sound to key doors
  • Added open sound to level doors
  • Added open sound to quest doors

Description

Addition of open and close doors sound to all type of doors.

Behaviour

Actual

Opens or closes a door and there's no sound.

Expected

Opens or closes a door and the open or close door sound should be heard.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

All the tests below should cast a sound for all spectators.

  • Opens a common door
  • Opens a quest door
  • Opens a level door
  • Opens a locked door
  • Closes a common door
  • Closes a quest door
  • Closes a level door
  • Closes a locked door

Test Configuration:

  • Server Version: 3.1.1
  • Client: 13.21.13839
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

changes:
- Added open sound to custom/normal doors
- Added open sound to key doors
- Added open sound to level doors
- Added open sound to quest doors
@dudantas dudantas changed the title Feat: Add open and close doors sound feat: add sound for open and close doors Dec 6, 2023
@dudantas dudantas merged commit 779b479 into opentibiabr:main Dec 6, 2023
10 checks passed
@phacUFPE phacUFPE deleted the feat-add-doors-open-close-sound branch December 6, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants