Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: changing exhaust functions to kv #2055

Merged
merged 3 commits into from
Jan 11, 2024
Merged

improve: changing exhaust functions to kv #2055

merged 3 commits into from
Jan 11, 2024

Conversation

luanluciano93
Copy link
Contributor

@luanluciano93 luanluciano93 commented Dec 24, 2023 •
edited
Loading

changing exhaust functions to kv:

  • player:setExhaustion(scope, seconds)
  • player:getExhaustion(scope)
  • player:hasExhaustion(scope)

luan
luan reviewed Dec 28, 2023
View reviewed changes
data/libs/functions/player.lua Outdated Show resolved Hide resolved
data/libs/functions/player.lua Outdated Show resolved Hide resolved
@luan
Copy link
Contributor

luan commented Dec 28, 2023

@luanluciano93 are these unused? I can't find any calls to these methods in the code.

@luanluciano93
Copy link
Contributor Author

@luanluciano93 are these unused? I can't find any calls to these methods in the code.

They are not used yet, but they are very useful, they can simplify a lot of existing code.

@luanluciano93 luanluciano93 requested a review from luan January 10, 2024 02:14
@luan luan added this pull request to the merge queue Jan 11, 2024
Merged via the queue into opentibiabr:main with commit 9aaee3b Jan 11, 2024
19 checks passed
@luanluciano93 luanluciano93 deleted the exhaustion-KV branch January 11, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majestyotbr majestyotbr majestyotbr approved these changes

@luan luan luan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luanluciano93 @luan @majestyotbr