Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in gamestore function and remove cooldown for item usage while walking #2485

Merged
merged 14 commits into from
Apr 26, 2024

Conversation

Mirkaanks
Copy link
Contributor

@Mirkaanks Mirkaanks commented Mar 23, 2024

fix: #2481

I believe the change is correct, however it removes a time limitation between actions while walking.
I'm not sure if this limitation should be placed there, such as:
g_configManager().getNumber(ACTIONS_DELAY_INTERVAL, __FUNCTION__));

Before (without modification):
2485-before

After (with modification):
2485-after

not delay between actions.

@Mirkaanks Mirkaanks marked this pull request as draft March 23, 2024 09:25
@Mirkaanks Mirkaanks marked this pull request as ready for review March 23, 2024 09:33
@Mirkaanks Mirkaanks marked this pull request as draft March 24, 2024 11:17
@Mirkaanks Mirkaanks marked this pull request as ready for review March 24, 2024 11:17
@Mirkaanks Mirkaanks changed the title Fix Item usage while walking Fix Item usage while walking and XP Boost. Mar 24, 2024
@Mirkaanks Mirkaanks changed the title Fix Item usage while walking and XP Boost. Fix Item usage while walking Mar 25, 2024
@luanluciano93
Copy link
Contributor

@Mirkaanks I don't know if this is the best solution... because that way I would be left without any exhaustion? Wouldn't it be correct to create another exhaustion check separate from actions?

@Mirkaanks
Copy link
Contributor Author

@MirkaanksNão sei se esta é a melhor solução... porque assim ficaria sem qualquer esgotamento? Não seria correto criar outra verificação de exaustão separada das ações?

I was in doubt, however I think this exists in the function that limits actions to 2s in config.lua.
I don't have time to check at the moment.

@elsongabriel elsongabriel changed the title Fix Item usage while walking fix: typo in gamestore function and remove cooldown for item usage while walking Apr 4, 2024
@elsongabriel
Copy link
Contributor

@Mirkaanks please, when you create a PR, put some images or video that you changed, to make it easier for those who are going to test.

@elsongabriel elsongabriel merged commit a820101 into opentibiabr:main Apr 26, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to move items in backpack when running around
6 participants