Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support outfit crashes on login #2526

Merged
merged 21 commits into from
Jul 18, 2024

Conversation

elsongabriel
Copy link
Contributor

@elsongabriel elsongabriel commented Apr 5, 2024

Description

If you try to log in with support/team outfit (in client 13.32 when open customize character window or login with GM, Community Manager or Customer Support outfit, this crashes, because starts with mount).

Behaviour

Actual

  1. You are GM or GOD and you login. If you are with support outfit, the client will be crashed.
  2. You are GM or GOD, you tried to change your outfit, and opened the customize character successfully, but you selected support outfit with the checkbox Mount checked, the client will be crashed either.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Test Configuration:

  • Server Version: Canary 3.1.2
  • Client: Tibia 13.32
  • Operating System: Windows 11 / Ubuntu 22.04

How to test this functionality:

  1. login as GM or GOD, and you are with citizen outfit for example.
  2. select any support outfit (GM, Community Manager, or Customer Support). If the mount checkbox is checked, the client will crash. But if you uncheck this checkbox, and select the support outfit, this will be ok.
  3. if you are with a support outfit set. when you log out and log in, the outfit will be changed to citizen (temporary outfit default).
  4. You can change your outfit again to any support outfit. BUT REMEMBER! You can't open customize character again, it will crash because the check Mount will be checked as default from client 13.32. You need to logout and login.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@luanluciano93
Copy link
Contributor

good

@Chapeleiiro
Copy link
Contributor

When I'm from /town city and I'm ghosting, he closes the client

@elsongabriel
Copy link
Contributor Author

elsongabriel commented Apr 8, 2024

When I'm from /town city and I'm ghosting, he closes the client

Yes, I saw this. When invisible or ghost. it's crashing client.. I need to verify.

#edit
@Chapeleiiro fixed.

…nt 13.32 when open customize character window or login with GM, CM ou CS outfit, this crashes, because starts with mount).
@elsongabriel elsongabriel force-pushed the fix/support-outfit-crashs branch from a15c132 to d30710c Compare April 23, 2024 13:45
Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and it is crashing with a specific looktype, left the crashing behavior in one of the comments.

src/creatures/creature.hpp Outdated Show resolved Hide resolved
src/game/game.cpp Outdated Show resolved Hide resolved
@elsongabriel elsongabriel merged commit f153224 into opentibiabr:main Jul 18, 2024
29 checks passed
@elsongabriel elsongabriel deleted the fix/support-outfit-crashs branch July 18, 2024 11:56
pasturryx pushed a commit to pasturryx/canary1 that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants