Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing attribute in bone fiddle #2531

Merged

Conversation

jeswilldbm
Copy link
Contributor

The moveevent is added so that when you equip the bone fiddle, it correctly grants you life Drain protection

Description

With this change, it is left like the other items, which when equipped, gives you the corresponding bonus.

Behaviour

Actual

Currently, if you equip the "bone fiddle" it does not give you the protection to life drain 5%

Expected

You should get the life drain protection when you equip it, this way:
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

It was tested before making any modification and it did not grant the bonus, then it was tested with the modification and now it does grant the protection satisfactorily.

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

The moveevent is added so that when you equip the bone fiddle, it correctly grants you life Drain protection
@elsongabriel elsongabriel changed the title fix attribute bone fiddle fix: add moveevent attribute to bone fiddle Apr 9, 2024
@elsongabriel elsongabriel changed the title fix: add moveevent attribute to bone fiddle fix: missing attribute in bone fiddle Apr 9, 2024
@elsongabriel elsongabriel merged commit 0f91db0 into opentibiabr:main Apr 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants