Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cupcakes #2537

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat: cupcakes #2537

merged 1 commit into from
Apr 17, 2024

Conversation

omarcopires
Copy link
Contributor

Each Cupcake can only be eaten once every 10 minutes, but they do not share this cooldown with each other. Furthermore, they also do not share their cooldown with any of the Hot Cuisine Quest or Hireling dishes.
The Cupcakes can be obtained as a reward from the A Piece of Cake event.

@elsongabriel
Copy link
Contributor

It can be continuos with just 1 file. You need to check what id is using. and create migration because you're changing storage to kv.

@omarcopires
Copy link
Contributor Author

It can be continuos with just 1 file. You need to check what id is using. and create migration because you're changing storage to kv.

I chose to keep these items separate, just as I did in the refactoring of the hirelings' foods. I believe this enhances readability and maintenance of the code, especially since each one behaves differently.

Regarding the migration, do you really think it's necessary? It's only 10 minutes anyway, and considering that the new cooldown will only take effect after the server is shut down, I don't think it's necessary to add a migration just for this.

@dudantas dudantas merged commit c43338e into opentibiabr:main Apr 17, 2024
19 checks passed
@omarcopires omarcopires deleted the cupcakes branch April 17, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants