feat: configurable party share range #2539
Merged
GitHub Actions / shellcheck
succeeded
Apr 13, 2024 in 0s
reviewdog [shellcheck] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (8)
docker/config.sh|13 col 11| Use grep -q instead of comparing output with [ -n .. ].
recompile.sh|65 col 30| To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).
tests/build_and_run.sh|7 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
tests/build_and_run.sh|8 col 38| Quote this to prevent word splitting.
tests/build_and_run.sh|8 col 38| Use $(...) notation instead of legacy backticks ....
tests/build_and_run.sh|10 col 1| Use a ( subshell ) to avoid having to cd back.
tests/build_and_run.sh|11 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
start_gdb.sh|18 col 6| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
Loading