Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transcendence applies correct status without unlocked stages #2566

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: transcendence applies correct status without unlocked stages #2566

merged 1 commit into from
Apr 23, 2024

Conversation

FelipePaluco
Copy link
Contributor

@FelipePaluco FelipePaluco commented Apr 21, 2024

Description

When you are using a legs with tier and the transcendence happens, if the player do not have any kind of stage unlocked in the wheel of destiny, the proper status like damage reduction, critical damage chance 100% and critical damage of 15% it's not applied. This PR fix the logic and remove early return that prevents the code from running and considering the case of no avatar stage unlocked.

thanks @luanluciano93 for the discussion and proposing new changes to the code.

Behaviour

Actual

  1. When transcendence is applied and player have no stage in avatar wheel, the proper status are not applied;
  2. When transcendence occurs, the status are not visually presented correctly to client (always stays in 0);

Expected

Transcendence is a special effect that triggers a shorter version of the Avatar spell (Stage 3). Which will grant all the bonuses from the spell, but last for only 7 seconds.

image

Fixes #2499

Fixes #2169

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Transform without any point applied in the avatar wheel tree;
  • Check if the status are displayed properly on the skills window and the damages changes;

Imagem do WhatsApp de 2024-04-20 à(s) 23 56 19_95532c74

Test Configuration:

  • Server Version: latest
  • Client: 13.32.14520
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@FelipePaluco FelipePaluco changed the title Fix/transcendence fix: trascendence not applying correct status when no stage are unlocked Apr 21, 2024
@FelipePaluco
Copy link
Contributor Author

MORE TESTS:

  • If I transform through transcendence I always come with stage 3 status
  • If I transform with magic spell with stage 1, I'm getting stage 1 status
  • If I transform with magic spell with stage 2, I am receiving stage 2 status
  • If I transform with magic spell with stage 3, I'm getting stage 3 status

@dudantas dudantas changed the title fix: trascendence not applying correct status when no stage are unlocked fix: transcendence applies correct status without unlocked stages Apr 23, 2024
@dudantas dudantas merged commit bd72f66 into opentibiabr:main Apr 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transcendance bug Bug: Transcendance Avatar
4 participants