fix: transcendence applies correct status without unlocked stages #2566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you are using a legs with tier and the transcendence happens, if the player do not have any kind of stage unlocked in the wheel of destiny, the proper status like damage reduction, critical damage chance 100% and critical damage of 15% it's not applied. This PR fix the logic and remove early return that prevents the code from running and considering the case of no avatar stage unlocked.
thanks @luanluciano93 for the discussion and proposing new changes to the code.
Behaviour
Actual
Expected
Transcendence is a special effect that triggers a shorter version of the Avatar spell (Stage 3). Which will grant all the bonuses from the spell, but last for only 7 seconds.
Fixes #2499
Fixes #2169
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist