Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vibrancy imbuement #2604

Closed
wants to merge 2 commits into from

Conversation

pennaor
Copy link
Contributor

@pennaor pennaor commented May 4, 2024

Description

This PR aims to implement global tibia vibrancy imbuement, allowing more flexible use of the principle that consists of a chance to deny a condition from being added/updated to the player.

By more flexible use I mean that it is possible to define more than one deny effect per imbuement, or even in another context in which imbuements are not used.

Definitions are gathered and resolved based on the highest chance of denial for a given condition.

Note: You can play around with adding/removing deflect conditions with talkactions. They were made just for testing, I plan to remove them.

Reference

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

Adding vibrancy imbuement

imbuing.mp4

25% chance to remove paralysis with intricate imbuement

25.mp4

For testing purposes: using 100% chance to remove paralysis

100.mp4

For testing purposes: using 50% chance to remove paralysis or fire damage condition in same boot

hibrid_test

hibrid.mp4

Test Configuration:

  • Server Version: 3.1.2
  • Client: 13.32
  • Operating System: Windows 10

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand area
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@elsongabriel
Copy link
Contributor

I think the pr #2494 it's like this..

@pennaor
Copy link
Contributor Author

pennaor commented May 4, 2024

omg

@pennaor
Copy link
Contributor Author

pennaor commented May 5, 2024

Closing the PR because I realized that I understood imbuement wrongly and the correct way was being implemented by @beats-dh in #2494. But some information might be useful, such as the boots that have the slot in items.xml. In tibia global it is currently called "Paralysis Removal" and the category descriptions are present in imbuements.xml. Using iconid 79 in vibrancy worked here.

@pennaor pennaor closed this May 5, 2024
@beats-dh
Copy link
Collaborator

beats-dh commented May 5, 2024

Closing the PR because I realized that I understood imbuement wrongly and the correct way was being implemented by @beats-dh in #2494. But some information might be useful, such as the boots that have the slot in items.xml. In tibia global it is currently called "Paralysis Removal" and the category descriptions are present in imbuements.xml. Using iconid 79 in vibrancy worked here.

This will help me, since I didn't have this information. If you want to test it and comment any feedback, feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants