Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: price mismatch between NPCs and a typo in the rent house letter message #2706

Closed
wants to merge 14 commits into from

Conversation

kaleohanopahala
Copy link
Contributor

@kaleohanopahala kaleohanopahala commented Jun 22, 2024

Good Night!

Explanation:
Monitoring feature to alert whenever there's a price mismatch between NPCs for item transactions.
This ensures any instance where an item is sold for less than its purchase price, or vice versa, is promptly identified and reported.

[2024-22-06 08:02:01.533] [warning] The item machete (3308) is being sold for a value greater than the value it is purchased for by the NPCs. Buy NPC: Nezil, Sell NPC: Obi
[2024-22-06 08:02:01.568] [warning] The item vial of water (2874) is being sold for a value greater than the value it is purchased for by the NPCs. Buy NPC: Ramina, Sell NPC: Rachel

-Fix: #2702
-Fix #2237 (18)

@majestyotbr majestyotbr changed the title NPC Price Discrepancy Monitoring and Notification fix: price mismatch between NPCs for items transactions Jun 22, 2024
@kaleohanopahala kaleohanopahala changed the title fix: price mismatch between NPCs for items transactions Fix: price mismatch between NPCs and a typo in the rent house letter message. Jun 23, 2024
@dudantas
Copy link
Member

It seems good. Please go to your fork settings and in github actions activate the workflow options, so that lua format runs normally here.

@kaleohanopahala
Copy link
Contributor Author

kaleohanopahala commented Jun 24, 2024

It seems good. Please go to your fork settings and in github actions activate the workflow options, so that lua format runs normally here.

Hello!
there’s no problem at my workflows config, for some reason, it only doesn’t work here
image

@majestyotbr majestyotbr changed the title Fix: price mismatch between NPCs and a typo in the rent house letter message. fix: price mismatch between NPCs and a typo in the rent house letter message Jun 25, 2024
@majestyotbr
Copy link
Contributor

majestyotbr commented Jul 10, 2024

Update your pull request and use the pull request template.

@majestyotbr
Copy link
Contributor

I recommend that you use other branch, not the main branch for pull requests.
Read more:
http://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

@Costallat Costallat force-pushed the main branch 5 times, most recently from e57725c to 0e5b5e7 Compare July 26, 2024 13:31
@majestyotbr
Copy link
Contributor

Due to lua check being broken in your fork, I will open a new PR with these changes and add you as a co-author.
Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Price Discrepancy Issue in NPC Trading. 30 Bugs encontrados durante testes.
4 participants