Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quests from version 7.24 revised #2724

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

htc16
Copy link
Contributor

@htc16 htc16 commented Jun 29, 2024

Description

Note: other quests from this version later became part of the missions of The Explorer Society Quest, therefore, I will leave them to be dealt with directly when the corresponding version of The Explorer Society Quest arrives.

Behavior

Real

I reviewed and corrected any quests that weren't working.

Delete options that are not relevant.

  • Bug fix (rolling change that fixes a problem)
  • New feature (rolling change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How this was tested

As I reviewed and modified the codes, I tested them.

Test Setup:

  • Server version: current
  • Client: 13
  • Operating system: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I performed a self-review of my own code
  • I checked the PR checks reports
  • I commented my code, especially in areas that were difficult to understand
  • I made corresponding changes to the documentation
  • My changes do not generate new warnings
  • I added tests that prove my fix is ​​effective or that my feature works

Copy link

@mattyx14 mattyx14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see this adjustment as necessary if it is always seen from the perspective that the server is running from 0

@htc16
Copy link
Contributor Author

htc16 commented Jun 29, 2024

@elsongabriel The part of the initial conversation with Lokuer was missing, before going to Kroox and finishing this stage, see the photo below.

image

https://www.tibiawiki.com.br/wiki/The_Postman_Missions_Quest

EDIT: If you think changing the order would be bad, I can create a new storage just for this NPC and keep the previous order.

@htc16
Copy link
Contributor Author

htc16 commented Jun 29, 2024

@mattyx14 Yes, that's why I created the migration so that if the server is not at 0, and there are players who did the quest, it will maintain the quest correctly.

@elsongabriel
Copy link
Contributor

@elsongabriel The part of the initial conversation with Lokuer was missing, before going to Kroox and finishing this stage, see the photo below.

image

https://www.tibiawiki.com.br/wiki/The_Postman_Missions_Quest

EDIT: If you think changing the order would be bad, I can create a new storage just for this NPC and keep the previous order.

try to answer the question, where I've created a "topic" for a better organization on this PR.
another thing.. I think you didn't understand what I said.

@majestyotbr
Copy link
Contributor

majestyotbr commented Jul 10, 2024

Update your pull request and use the pull request template.

@htc16
Copy link
Contributor Author

htc16 commented Jul 15, 2024

This PR reviews many of these quests at #618

@majestyotbr majestyotbr changed the title Tibia-Quests-Review-7.24 fix: quests from version 7.24 revised Jul 15, 2024
@majestyotbr majestyotbr merged commit e30b0af into opentibiabr:main Jul 25, 2024
17 checks passed
Roaaw pushed a commit to Roaaw/canary that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants