Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quests from version 8.00 to 8.74 revised #2765

Merged
merged 118 commits into from
Aug 16, 2024

Conversation

htc16
Copy link
Contributor

@htc16 htc16 commented Jul 22, 2024

Description

At position {x = 32134, y = 31095, z = 6} there is port id 7038 that needs to be changed to id 7040.
In positions {x = 32203, y = 31022, z = 14} and {x = 32204, y = 31022, z = 14} replace port id 7038 with id 7040

At Position: (33193, 31868, 12) the black map is appearing.

In the first part of aritos I managed to include some missing lines.
In the second part, Nomads Land, there is not even any development for this phase, so I will leave it to a more competent soul to resolve this phase.

At position {x = 33286, y = 32444, z = 8}, {x = 33281, y = 32442, z = 8}, {x = 33284, y = 32450, z = 8}, {x = 33278, y = 32450, z = 8} and {x = 33276, y = 32444, z = 8} all statues that have id 2062 need to be exchanged for statue id 2063.
Next to the boss Koshei The Deathless there needs to be a Bonebeast monster, which can be placed in Position: (33270, 32410, 12)

This quest was integrated into Arito's Task Quest, being the non-existent part of the quest as mentioned above.

In Position: (32605, 31754, 9) change port id 6251 to port id 6252

image
This part is missing from the map, I'll send it to the Discord downloads tab to be incorporated. Also, to make it easier, the positions of the BED in the photo need to be in the following positions: {x = 32659, y = 31852, z = 13} and {x = 32660, y = 31852, z = 13}

This is a 4-person quest, so I'll skip it and we can get feedback from the community about it later. Anyway, I was able to start the quest, but we'll need to test the rest.

At position (32972, 31461, 10) replace ID 1987 with ID 1986

The Forgotten Passage additional quest part is missing: the correct place would be 32638, 31960, 10 in the script, however this area does not yet exist on the Kazordoon map.

At position {x = 33233, y = 32280, z = 12} place a dragon's body ID 4286 on the map.

I believe that this area at Position: (10287, 10113, 1) is a bug, and could be erased from the map, as well as its NPC.

At positions:
33385, 31139, 8
33385, 31134, 8
33385, 31126, 8
33385, 31119, 8
33385, 31118, 8
33380, 31093, 8
33380, 31085, 8
There is an item ID 11257 or 11258 behind each door, remove only these items as this will be updated by script.

I'm currently working on adding all quests to the PR. Given the large number of quests, I would like to ask for your help and collaboration to close this PR as quickly as possible. If you are interested in helping, choose one of the quests to review, open a PR for it, and link to this PR. All help is welcome!

Note1: my focus is on quests, therefore, the quest log for a quest may be missing as this is not shown in the quest tutorial lists. I study tutorials and release fix ones or develop something related to the tutorial.

Note2: I have limitations as this is the first time I am willing to do this, so please consider that some codes may not be the best but what matters is the intention and this can be improved in the future if someone finds it appropriate to do so.

Note3: I'm taking the opportunity to catalog all the aids and uids so that we can eventually modify and change them in the future directly through the script.

Note4: this PR needs some updates to the map that were reported above.

Note5: I was unable to place the writings in the books, only through the map editor, but this did not influence the development of the quest, so I left this for a future review.

Behavior

Real

I reviewed and corrected any quests that weren't working.

Delete options that are not relevant.

  • Bug fix (rolling change that fixes a problem)
  • New feature (rolling change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How this was tested

As I reviewed and modified the codes, I tested them.

Test Setup:

  • Server version: current
  • Client: 13
  • Operating system: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I performed a self-review of my own code
  • I checked the PR checks reports
  • I commented my code, especially in areas that were difficult to understand
  • I made corresponding changes to the documentation
  • My changes do not generate new warnings
  • I added tests that prove my fix is ​​effective or that my feature worksNightmare Outfits Quest

htc16 and others added 30 commits July 22, 2024 16:39
… for example, The Ice Islands Quest, Norseman Outfits Quest and Shards of Ancient Winters Quest, as well as others.
is in Tibia Tales, so I will keep it
I just wasn't able to add Lord Koshei the Curious' Parchment to the shelf, as I don't know what item that is, but that's easy once we have that information, besides the quest is now possible.
I kept this quest without the need for missions, I think this mission is purely useless, but the reward I kept normal.
@majestyotbr
Copy link
Contributor

Thanks for your contribution.
Updated global map:
https://github.com/opentibiabr/canary/releases/download/v3.1.0/otservbr.otbm

@majestyotbr majestyotbr merged commit 645237b into opentibiabr:main Aug 16, 2024
15 of 18 checks passed
@murilo09 murilo09 linked an issue Aug 22, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yalahari last room Fix
3 participants