Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable canary map editor assets otbm version #2777

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Jul 28, 2024

DEPENDS ON opentibiabr/remeres-map-editor#70

Description

Enables the read of canary's map editor assets otbm version.

Behaviour

Actual

Do not read the assets otbm version.

Expected

Reads the assets otbm version.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

  • Create or save a map with the assets otbm version of canary's map editor.
  • Run the server and it should load the map normally.

Test Configuration:

  • Server Version: Latest.
  • Client: 13.32
  • Operating System: Windows 10

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

Qodana for C/C++

2 new problems were found

Inspection name Severity Problems
magic-numbers 🔶 Warning 1
function-cognitive-complexity 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

Copy link
Contributor

github-actions bot commented Oct 5, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Oct 5, 2024
Copy link

@murilo09 murilo09 removed the Stale No activity label Oct 14, 2024
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Nov 14, 2024
@github-actions github-actions bot removed the Stale No activity label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants