Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added preyable and isPreyExclusive flags to prey monsters #2785

Merged

Conversation

Maticoz
Copy link
Contributor

@Maticoz Maticoz commented Aug 2, 2024

Description

Adds two new flags in monsters.
isPreyable and isPreyExclusive, first one is responsible for to allow skip monster from prey system even if have bestiary.
Second one is using to skip some monsters from (free/gold) reroll, these mobs only available from 5 preycard option.

isPreyExclusive flag added only to those monsters (168 monsters edited)
https://tibia.fandom.com/wiki/Prey_System/Creature_List

Behaviour

Expected

isPreyable - if false, skip monster from preyslot (skipping on preyslot reroll), and dialog information this monster is not avalilable to preyslot.
isPreyExclusive - if true, skips monster from preyslot, but allows to select from 5 preycard option.

Type of change

Please delete options that are not relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested

  • Adding flag ispreyable with value false, and force to use his raceid, with full logging
    Chicken is only a example.
    image
    image

  • Adding flag isPreyExclusive with value true, and force to use his race. Rerolling preys for gold and watching logs
    image

Test Configuration:

  • Server Version: Latest
  • Client: 13.32
  • Operating System: W10

Checklist

  • [X ] My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@Maticoz Maticoz marked this pull request as ready for review August 2, 2024 14:12
@Maticoz Maticoz closed this Aug 6, 2024
@Maticoz Maticoz deleted the feat_PreyableExclusivePreyableMonsters branch August 6, 2024 19:16
@Maticoz Maticoz restored the feat_PreyableExclusivePreyableMonsters branch August 6, 2024 19:18
@majestyotbr majestyotbr reopened this Aug 6, 2024
@dudantas dudantas changed the title feat: adds preyable and ispreyexclusive flags to monsters with handling feat: added preyable and isPreyExclusive flags to prey monsters Aug 19, 2024
@dudantas dudantas merged commit dadf8fb into opentibiabr:main Aug 19, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants