Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nimmersatt's monsters #2805

Closed
wants to merge 13 commits into from
Closed

feat: Nimmersatt's monsters #2805

wants to merge 13 commits into from

Conversation

hecmo94
Copy link
Contributor

@hecmo94 hecmo94 commented Aug 9, 2024

Description

Add Nimmersatt's monsters:

  • Dragolisk,
  • Wardragon,
  • Mega Dragon.
  • Step in Teleport.

Type of change

  • New feature (non-breaking change which adds functionality)

Test Configuration:

  • Server Version: Latest.
  • Client: 13.32
  • Operating System: Windows 10

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@hecmo94 hecmo94 changed the title Nimmerset monster / teleport /items feat: Nimmerset's Monster Aug 9, 2024
@majestyotbr majestyotbr changed the title feat: Nimmerset's Monster feat: Nimmersatt's monsters Aug 9, 2024
@dudantas
Copy link
Member

It seems to me that everything is fine, however, the lua check is not running, which causes the pull to be blocked for merge.

@majestyotbr
Copy link
Contributor

Due to lua check being broken in your fork, I will open a new PR with these changes and add you as a co-author.
Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants