Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new liquids 13.40 #2814

Merged
merged 7 commits into from
Aug 16, 2024
Merged

feat: add new liquids 13.40 #2814

merged 7 commits into from
Aug 16, 2024

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Aug 14, 2024

Description

Addition of new 13.40 liquids. This MR is also to works with RME, the PR opentibiabr/remeres-map-editor#104 introduces a fix and addition of the liquid "chocolate" of the version 13.40.

Behaviour

Actual

Login in the server with the chocolate fluid added in RME map that is being used in the server and it shouldn't show.

Expected

Login in the server with the chocolate fluid added in RME map that is being used in the server and it should show.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Add in RME the chocolate fluid.
  • Login in the server.
  • Check if the chocolate fluid is being displayed correctly

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

github-actions bot commented Aug 16, 2024

Qodana for C/C++

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@majestyotbr majestyotbr merged commit bc852f2 into main Aug 16, 2024
36 checks passed
@majestyotbr majestyotbr deleted the feat_new_liquids branch August 16, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants