fix: only take screenshot when achievement is successfully added #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the luaPlayerAddAchievement method so that the screenshot (sendTakeScreenshot) is only taken when the achievement is successfully added to the player. Previously, the screenshot was taken regardless of the success of the operation.
Capitalizes "Title System" in the log message for consistency. This change updates the log entry to use "Title System" instead of "Title system".
Introduces a new constant, SCREENSHOT_TYPE_GIFTOFLIFE, with the value 13, to support a new type of screenshot within the game's screenshot capture system. The constant has been added to the existing set of screenshot types to accommodate a new feature or specific event identified as "Gift of Life."
Type of change
Checklist