feat: multiworld system

[phacUFPE]

Description

SOME CONFIGS WILL BE REMOVED FROM config.lua AND WILL BE USED FROM DATABASE, TABLE worlds!

Implementation of the multiword system.

This PR is in DRAFT due to the necessary modifications:

• Update login protocol bytes
• Update schema
• Create schema migrations
• Update highscores
• Load which world the running server is
• Hirelings spawn and save
• Test everything

Using MyAAC will need the following PR: opentibiabr/myaac#110

Behaviour

Actual

Multiword system isn't enabled and available

Expected

Multiword system be enabled and available

Credits and inspired by: opentibiabr/otservbr-global-archived#929

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested

• Test houses
• Test mailbox
• Test hirelings
• Test bank
• Test highscores
• Test guilds
• ...

Test Configuration:

• Server Version: main (latest)
• Client: 13.40 (latest)
• Operating System: Windows 11

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[github-actions]

Qodana for C/C++

24 new problems were found

Inspection name	Severity	Problems
misra-cpp2008-5-0-6	🔶 Warning	5
unroll-loops	🔶 Warning	2
misra-cpp2008-5-0-13	🔶 Warning	2
easily-swappable-parameters	🔶 Warning	2
unnecessary-value-param	🔶 Warning	2
misra-cpp2008-0-1-7	🔶 Warning	2
id-dependent-backward-branch	🔶 Warning	2
suspicious-string-compare	🔶 Warning	1
implicit-bool-conversion	🔶 Warning	1
prefer-member-initializer	🔶 Warning	1
misra-cpp2008-6-4-2	🔶 Warning	1
else-after-return	🔶 Warning	1
avoid-do-while	🔶 Warning	1
function-cognitive-complexity	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

• Register at Qodana Cloud and configure the action
• Use GitHub Code Scanning with Qodana
• Host Qodana report at GitHub Pages
• Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[phacUFPE]

This pull request is open for testing, please be aware that it may contain a lot of bugs, if you find anything out of order that was not supposed to happen, please report commenting in here.

[DaviRJ]

Apparently, the getWorldConfigsById function, which is called in CanaryServer::loadThisWorld, is returning an invalid value, causing errors later on.

canary_server.cpp line 150

Error on line 176 becouse world->type is invalid?

[elsongabriel]

Apparently, the getWorldConfigsById function, which is called in CanaryServer::loadThisWorld, is returning an invalid value, causing errors later on.

canary_server.cpp line 150

Error on line 176 becouse world->type is invalid?

something in your config.lua could be wrong. by the way, i'll check.

[DaviRJ]

something in your config.lua could be wrong. by the way, i'll check.

I've checked the config.lua I'm using and the config.lua.dist. Aside from some settings like database access, server name, and rate, I added the toggleServerIsRetroPVP configuration as false.

Below is the difference between the two files (on the left is config.lua.dist).

https://www.diffchecker.com/ZgLRqJEy/

[OpenTibiaMX]

[warning] [ConfigManager::missingConfigWarning]: Missing configuration for identifier: toggleServerIsRetroPVP

[elsongabriel]

[warning] [ConfigManager::missingConfigWarning]: Missing configuration for identifier: toggleServerIsRetroPVP

now we use the server type from database.

[DaviRJ]

something in your config.lua could be wrong. by the way, i'll check.

I've checked the config.lua I'm using and the config.lua.dist. Aside from some settings like database access, server name, and rate, I added the toggleServerIsRetroPVP configuration as false.

Below is the difference between the two files (on the left is config.lua.dist).

https://www.diffchecker.com/ZgLRqJEy/

From what I've seen while debugging, the function getWorldConfigsById is always receiving an empty ID (or is ignoring the received parameter???).

In this test I've performed, "Received ID: " is always printed, even though the variable worldId is set correctly.

Could it be a type mismatch?

[elsongabriel]

something in your config.lua could be wrong. by the way, i'll check.

I've checked the config.lua I'm using and the config.lua.dist. Aside from some settings like database access, server name, and rate, I added the toggleServerIsRetroPVP configuration as false.
Below is the difference between the two files (on the left is config.lua.dist).
https://www.diffchecker.com/ZgLRqJEy/

From what I've seen while debugging, the function getWorldConfigsById is always receiving an empty ID (or is ignoring the received parameter???).

In this test I've performed, "Received ID: " is always printed, even though the variable worldId is set correctly.

Could it be a type mismatch?

do you have table worlds updated with recent changes? and your config.lua has worldId with the same in table worlds?

[DaviRJ]

do you have table worlds updated with recent changes? and your config.lua has worldId with the same in table worlds?

After the last update, this isn't occurring anymore.

I've been running this version for a couple of days. Everything seems fine. I've tested guilds, market, war, character creation, etc. I believe I now need to test Myacc a bit more, but regarding Canary, I haven't found any problems.

[github-actions]

Qodana for C/C++

1040 new problems were found

Inspection name	Severity	Problems
misra-cpp2008-5-0-11	🔶 Warning	893
err33-c	🔶 Warning	37
static-accessed-through-instance	🔶 Warning	18
misra-cpp2008-5-0-5	🔶 Warning	13
misra-cpp2008-0-1-7	🔶 Warning	5
misra-cpp2008-5-2-12	🔶 Warning	5
function-cognitive-complexity	🔶 Warning	5
misra-cpp2008-4-5-2	🔶 Warning	5
magic-numbers	🔶 Warning	5
misra-cpp2008-5-0-13	🔶 Warning	4
implicit-bool-conversion	🔶 Warning	4
misra-cpp2008-5-0-6	🔶 Warning	4
narrowing-conversions	🔶 Warning	3
unnecessary-value-param	🔶 Warning	3
misra-cpp2008-5-3-1	🔶 Warning	3
unroll-loops	🔶 Warning	3
use-starts-ends-with	🔶 Warning	3
id-dependent-backward-branch	🔶 Warning	3
unnecessary-copy-initialization	🔶 Warning	2
for-range-copy	🔶 Warning	2
easily-swappable-parameters	🔶 Warning	2
misra-cpp2008-6-4-2	🔶 Warning	2
else-after-return	🔶 Warning	2
duplicate-include	🔶 Warning	2
simplify-boolean-expr	🔶 Warning	2
misra-cpp2008-6-4-5	🔶 Warning	1
no-automatic-move	🔶 Warning	1
too-small-loop-variable	🔶 Warning	1
suspicious-string-compare	🔶 Warning	1
prefer-member-initializer	🔶 Warning	1
convert-member-functions-to-static	🔶 Warning	1
avoid-do-while	🔶 Warning	1
pass-by-value	🔶 Warning	1
inconsistent-declaration-parameter-name	🔶 Warning	1
redundant-casting	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

• Register at Qodana Cloud and configure the action
• Use GitHub Code Scanning with Qodana
• Host Qodana report at GitHub Pages
• Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[github-actions]

This PR is stale because it has been open 45 days with no activity.

[github-actions]

This PR is stale because it has been open 45 days with no activity.