Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiworld system #2826

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

feat: multiworld system #2826

wants to merge 46 commits into from

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Aug 17, 2024

Description

SOME CONFIGS WILL BE REMOVED FROM config.lua AND WILL BE USED FROM DATABASE, TABLE worlds!

Implementation of the multiword system.

This PR is in DRAFT due to the necessary modifications:

  • Update login protocol bytes
  • Update schema
  • Create schema migrations
  • Update highscores
  • Load which world the running server is
  • Hirelings spawn and save
  • Test everything

Using MyAAC will need the following PR: opentibiabr/myaac#110

Behaviour

Actual

Multiword system isn't enabled and available

Expected

Multiword system be enabled and available

image

Credits and inspired by: opentibiabr/otservbr-global-archived#929

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

  • Test houses
  • Test mailbox
  • Test hirelings
  • Test bank
  • Test highscores
  • Test guilds
  • ...

Test Configuration:

  • Server Version: main (latest)
  • Client: 13.40 (latest)
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

This comment was marked as outdated.

@lBaah

This comment was marked as resolved.

@phacUFPE phacUFPE force-pushed the phacUFPE/multiworld_system branch 2 times, most recently from 08ad270 to 8be898c Compare August 18, 2024 15:35
config.lua.dist Outdated Show resolved Hide resolved
@phacUFPE phacUFPE force-pushed the phacUFPE/multiworld_system branch from b7c6568 to 0e0eb3b Compare August 22, 2024 18:08
@phacUFPE
Copy link
Contributor Author

phacUFPE commented Aug 26, 2024

This pull request is open for testing, please be aware that it may contain a lot of bugs, if you find anything out of order that was not supposed to happen, please report commenting in here.

@phacUFPE phacUFPE marked this pull request as ready for review August 26, 2024 16:24
@elsongabriel

This comment was marked as outdated.

@elsongabriel elsongabriel marked this pull request as draft September 6, 2024 12:10
@DaviRJ

This comment was marked as outdated.

@elsongabriel

This comment was marked as outdated.

@DaviRJ

This comment was marked as outdated.

@phacUFPE phacUFPE marked this pull request as ready for review September 24, 2024 19:29

This comment was marked as outdated.

Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Oct 26, 2024
@murilo09 murilo09 removed the Stale No activity label Oct 30, 2024
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Nov 30, 2024
@elsongabriel elsongabriel removed the Stale No activity label Dec 6, 2024
@murilo09 murilo09 marked this pull request as draft December 31, 2024 04:45
@phacUFPE phacUFPE force-pushed the phacUFPE/multiworld_system branch from 7fc999a to 8cbee67 Compare January 18, 2025 05:10
@phacUFPE
Copy link
Contributor Author

Conflicts solved, ready for testing again.

@phacUFPE phacUFPE marked this pull request as ready for review January 18, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants