Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bakragore icons talkaction #2828

Merged
merged 1 commit into from
Sep 6, 2024

fix: remove bakragore icons

eab6d8e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: remove bakragore icons talkaction #2828

fix: remove bakragore icons
eab6d8e
Select commit
Loading
Failed to load commit list.
GitHub Actions / shellcheck succeeded Aug 19, 2024 in 0s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (8)

tests/build_and_run.sh|7 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
tests/build_and_run.sh|8 col 38| Quote this to prevent word splitting.
tests/build_and_run.sh|8 col 38| Use $(...) notation instead of legacy backticks ....
tests/build_and_run.sh|10 col 1| Use a ( subshell ) to avoid having to cd back.
tests/build_and_run.sh|11 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
docker/config.sh|13 col 11| Use grep -q instead of comparing output with [ -n .. ].
recompile.sh|65 col 30| To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).
start_gdb.sh|18 col 6| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.