Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong params in creatureSetIcon function #2835

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

luanluciano93
Copy link
Contributor

Description

The setIcon function does not work when used in the "Modifications" category, this problem has existed since the creation of the function in PR #1585

Behaviour

Actual

Test with the above command and it will not work without changing this PR.

Expected

Use the setIcon function with the "Modifications" category and the correct category icon appears.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

You can test with the script below:

local icons = TalkAction("!icon")

function icons.onSay(player, words, param)
	player:setIcon("test", CreatureIconCategory_Modifications, CreatureIconModifications_Influenced, 3)
	return true
end

icons:groupType("normal")
icons:register()

Test Configuration:

  • Server Version: Canary Main
  • Client: 13.40
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@elsongabriel elsongabriel changed the title fix: set icon with "modifications" category fix: params in setIcon function Aug 21, 2024
@elsongabriel elsongabriel changed the title fix: params in setIcon function fix: params in creatureSetIcon function Aug 21, 2024
@dudantas dudantas merged commit 5db19a9 into opentibiabr:main Aug 26, 2024
22 checks passed
@dudantas dudantas changed the title fix: params in creatureSetIcon function fix: wrong params in creatureSetIcon function Aug 26, 2024
@luanluciano93 luanluciano93 deleted the fix-set-icon branch August 28, 2024 03:04
s2leandro155 pushed a commit to s2leandro155/rzyns that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants