Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotten Blood Quest Stairs #2883

Closed
wants to merge 4 commits into from
Closed

Rotten Blood Quest Stairs #2883

wants to merge 4 commits into from

Conversation

andreoam
Copy link
Contributor

@andreoam andreoam commented Sep 8, 2024

Description

Added Rotten Blood quest stairs

Behavior

Real

Rotten Blood quest stairs not working to climb

Expected

Climb Rotten Blood quest stairs

Change Type

  • Bugfix (non-drastic change that fixes a problem)
  • New feature (non-drastic change that adds functionality)

How this was tested

Walking through the quest I noticed that the stairs could not be climbed, only descended, I added the stairs IDs in the xml to fix the problem.

Test setup:

  • Server version: 3.1.2
  • Client: 13.40
  • Operating system: windows/linux

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-assessment of my own code
  • I have checked the PR verification reports
  • I have commented my code, particularly in areas that are difficult to understand
  • I have made corresponding changes to the documentation
  • My changes do not generate new warnings
  • I have added tests that prove that my fix is ​​effective or that my feature works

@elsongabriel
Copy link
Contributor

elsongabriel commented Sep 9, 2024

your pr doesn't make sense! you're removing some items.. the stairs fixes, need to be done on the map.
you aren't following XML indentation rules.. etc..
you are changing files that are in another PRs.
@andreoam please review your changes.

@elsongabriel elsongabriel marked this pull request as draft September 9, 2024 14:30
@andreoam
Copy link
Contributor Author

andreoam commented Sep 9, 2024

@elsongabriel as escadas no mapa está correta, a única coisa que fiz foi adicionar os IDs dela no itens.xml, pós os IDs delas não existia.
Não foi removido item algum do itens.xml, apenas removi os comentários que induzem o player acessar links externos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants