Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename removeMoneyBank to removeTotalMoney and fix format i… #2912

Closed

Conversation

omarcopires
Copy link
Contributor

@omarcopires omarcopires commented Sep 24, 2024

Description

  • Optimized Player.removeTotalMoney function by reducing redundant calls to getBankBalance.
  • Improved efficiency when updating the bank balance after debiting.
  • Code is clearer and more organized, while preserving existing functionality.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@phacUFPE
Copy link
Contributor

Why didn't you applied these refactors to the first refactor that you've made in #2887 ?

@omarcopires
Copy link
Contributor Author

Why didn't you applied these refactors to the first refactor that you've made in #2887 ?

I've been stuck with other issues with my server and I just remembered to send these updates after the previous merge notification!

@phacUFPE
Copy link
Contributor

Why didn't you applied these refactors to the first refactor that you've made in #2887 ?

I've been stuck with other issues with my server and I just remembered to send these updates after the previous merge notification!

You should pay attention, the PR that I mentioned that you've created that is already merged should be in DRAFT, since you had more content to add.

I will be closing this PR because you were warned before about this behavior that should not happen anymore.

Be advised again, do not open for review a PR that you know that have more content to be added.

@phacUFPE phacUFPE closed this Sep 24, 2024
@omarcopires omarcopires deleted the refactor-removeMoney branch September 25, 2024 18:29
@omarcopires omarcopires restored the refactor-removeMoney branch October 17, 2024 19:07
@omarcopires omarcopires deleted the refactor-removeMoney branch October 17, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants