enhance: change from to std::ranges::find_if in Chat::getPrivateChannel #2996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the iteration and conditional logic used to find a specific
PrivateChatChannel
inprivateChannels
to usestd::ranges::find_if
. The updated version of the code improves readability by reducing boilerplate, leveraging structured bindings and modern C++ features.Behaviour
Actual
Iterating over
privateChannels
using a for loop and checking if the owner's GUID matches the player's GUID manually.Expected
Using
std::ranges::find_if
to streamline the search for the private channel, simplifying the code by using a lambda and structured bindings.Type of change
Checklist