improve: fix thread pool shutdown #3000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where the
ThreadPool::shutdown()
method would hang indefinitely due to waiting on threads without proper condition signaling.Depuration with gdb:
Normal loading:
Behaviour
Actual
The
ThreadPool
shutdown process hangs indefinitely with the message "Shutting down thread pool..." without completing.Expected
The
ThreadPool
should properly notify threads to complete their tasks and shut down gracefully, avoiding hanging indefinitely.Type of change
How Has This Been Tested
The fix was tested by reproducing the shutdown scenario where the hanging issue occurred. The shutdown process now correctly notifies threads to complete, and the shutdown process finishes as expected.
ThreadPool
after an error in loading, confirming no indefinite hang.Checklist