Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fragment workshop #3008

Merged
merged 11 commits into from
Oct 29, 2024
Merged

feat: fragment workshop #3008

merged 11 commits into from
Oct 29, 2024

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Oct 23, 2024

Description

Full Fragment workshop:

  • Gem improve system
  • Crusher and Amber Crusher actions
  • NPC's selling Crusher and Amber Crusher

Replaced some includes with forward declaration on wheel of destiny files.

Behaviour

Actual

It is impossible to improve a gem, missing feature.

Expected

It is possible to improve gems, break them and the bonuses working.

Fixes #2861

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Reveal a greater gem
  • Improve the gem grade
  • Check the bonus being applied
  • Try breaking the gems with Crusher and Amber Crusher
  • Crusher should vanish if used 10 times (10 charges)
  • Amber Crusher should never vanish (no charges, permanent)

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Co-authored-by: LuN [email protected]
Co-authored-by: Omega [email protected]

@phacUFPE phacUFPE force-pushed the feat_wheel_fragments branch 2 times, most recently from f4b03a4 to 5d1e63d Compare October 23, 2024 23:06
@phacUFPE phacUFPE force-pushed the feat_wheel_fragments branch 2 times, most recently from b6aece1 to 0b8761f Compare October 23, 2024 23:51
@phacUFPE phacUFPE force-pushed the feat_wheel_fragments branch from 0b8761f to 3e59327 Compare October 24, 2024 00:00
@jeswilldbm

This comment was marked as resolved.

@jeswilldbm

This comment was marked as resolved.

@phacUFPE

This comment was marked as outdated.

@phacUFPE phacUFPE force-pushed the feat_wheel_fragments branch from dfd7092 to c31b462 Compare October 27, 2024 22:02
Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, good job removing the circular inclusions!
I just have a few things to note to avoid copying objects unnecessarily.

src/creatures/players/wheel/player_wheel.cpp Outdated Show resolved Hide resolved
src/creatures/players/wheel/player_wheel.cpp Outdated Show resolved Hide resolved
src/creatures/players/wheel/player_wheel.cpp Outdated Show resolved Hide resolved
src/creatures/players/wheel/player_wheel.cpp Outdated Show resolved Hide resolved
src/creatures/players/wheel/player_wheel.cpp Outdated Show resolved Hide resolved
src/creatures/players/wheel/player_wheel.cpp Outdated Show resolved Hide resolved
src/creatures/players/wheel/player_wheel.cpp Show resolved Hide resolved
src/creatures/players/wheel/player_wheel.cpp Outdated Show resolved Hide resolved
@phacUFPE
Copy link
Contributor Author

It looks great, good job removing the circular inclusions! I just have a few things to note to avoid copying objects unnecessarily.

Fixed!

@phacUFPE phacUFPE force-pushed the feat_wheel_fragments branch from b74e75b to 7f32254 Compare October 28, 2024 06:43
Copy link

@dudantas dudantas merged commit d6c5ec3 into main Oct 29, 2024
43 checks passed
@dudantas dudantas deleted the feat_wheel_fragments branch October 29, 2024 15:20
@jeswilldbm jeswilldbm mentioned this pull request Nov 3, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fragment Workshop
5 participants