-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fragment workshop #3008
feat: fragment workshop #3008
Conversation
f4b03a4
to
5d1e63d
Compare
b6aece1
to
0b8761f
Compare
0b8761f
to
3e59327
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
dfd7092
to
c31b462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great, good job removing the circular inclusions!
I just have a few things to note to avoid copying objects unnecessarily.
Fixed! |
b74e75b
to
7f32254
Compare
Quality Gate passedIssues Measures |
Description
Full Fragment workshop:
Replaced some includes with forward declaration on wheel of destiny files.
Behaviour
Actual
It is impossible to improve a gem, missing feature.
Expected
It is possible to improve gems, break them and the bonuses working.
Fixes #2861
Type of change
How Has This Been Tested
Test Configuration:
Checklist
Co-authored-by: LuN [email protected]
Co-authored-by: Omega [email protected]