fix: supreme revelation modifiers initialization

[dudantas]

Description

This fixes several issues causing the "Supreme Revelation Perks" from the wheel to not work correctly.

Firstly, the m_value in wheel_gems.hpp was not being initialized, resulting in the extra points value always being 0.
Secondly, the order of variable initialization was incorrect, which caused the points to be used before they were loaded, also resulting in a value of 0.

Additionally, smaller functions were created to improve readability and maintainability, thus preventing future errors like this one.

Removed several unused Lua functions.

Behaviour

Actual

Attempting to use "Supreme Revelation Perks" results in no points being applied.

Expected

"Supreme Revelation Perks" should correctly apply the expected extra points.

Fixes #2780

How Has This Been Tested

1. Insert a supreme revelation gem (tested with "Exori Amp Kor").
2. Fill all slots on one side, except for one slot worth 150 points (making it a total of 850).
3. With the supreme revelation gem active, the system correctly counted the total as 1000 points due to the additional 150 points provided by the gem, even with one slot missing. And the spell cooldown is set from 13 to 10 (the supreme revelation bonus).

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• My changes generate no new warnings

[dudantas]

Vessels stopped to work, I tested with a Knight using a lesser gem that grants 100 mana, and it didn't applied. It seems to be because the vessel bonus are applied before the player bonus register and when the player bonus is registered it resets the stats, meaning that all vessel stats applied will be lost.

Fixed, please test again.

[phacUFPE]

Now it's working as expected.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud