Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: erase forgeable monsters and reduce spawn time #3014

Merged
merged 5 commits into from
Oct 28, 2024
Merged

fix: erase forgeable monsters and reduce spawn time #3014

merged 5 commits into from
Oct 28, 2024

Conversation

murilo09
Copy link
Contributor

@murilo09 murilo09 commented Oct 25, 2024 •
edited
Loading

Description

  • Influenced and Fiendish monsters wrong buffs
  • Influenced monsters taking a long time to spawn
  • Only replace forgeable monsters when necessary

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@murilo09 murilo09 changed the title fix: mitigate cpu usage problem and decrease influenced spawn time fix: mitigate cpu usage in forgeable monsters and decrease influenced spawn time Oct 25, 2024
@W4gNII

This comment was marked as outdated.

Sign in to view
@murilo09 murilo09 changed the title fix: mitigate cpu usage in forgeable monsters and decrease influenced spawn time fix: erase forgeable monsters every 10 seconds and decrease influenced spawn time Oct 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dudantas
Copy link
Member

dudantas commented Oct 27, 2024 •
edited
Loading

Man, on testing your pr in production all results are same of previous version high cpu usage and inconsistent fps above 100 players on

What fixes this problem is this pull: #2998

The current pull is to improve a cpu spike with forgeable monsters only.

@dudantas dudantas changed the title fix: erase forgeable monsters every 10 seconds and decrease influenced spawn time fix: erase forgeable monsters and reduce spawn time Oct 28, 2024
@dudantas dudantas merged commit 5244ed5 into main Oct 28, 2024
44 checks passed
@dudantas dudantas deleted the fix-influenced branch October 28, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murilo09 @W4gNII @dudantas