Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: party onLeave by forcing exit #3018

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

kaleohanopahala
Copy link
Contributor

If Party:onLeave() is used and returns false when a player is dying or logged out, the player is not properly removed from the party.

Issue #3013

@murilo09
Copy link
Contributor

When a player dies in a party, they are not removed. They only leave when they log out.
Example

@murilo09 murilo09 linked an issue Oct 25, 2024 that may be closed by this pull request
5 tasks
@kaleohanopahala
Copy link
Contributor Author

When a player dies in a party, they are not removed. They only leave when they log out. Example

Ya, the logic remains the same, but there is a check that will force the removal of the player who is out of the party's range and/or removed from it.

@murilo09 murilo09 changed the title Fix Party onleave by forcing exit. fix: party onLeave by forcing exit Oct 25, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@dudantas dudantas merged commit ef97a60 into opentibiabr:main Oct 28, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Party System - Member is death not working shared
4 participants