cleanup: Game::checkCreatures

[mehah]

The loop by iterator has been replaced by erase_if, as it is visually cleaner and more intuitive. In terms of performance, there was not much gain, as both use object reallocation, perhaps a slight improvement, as erase_if uses std::move to reallocate the last object.

A dead code that is never called has also been removed, as this code is already called by Creature::changeHealth on line 892

Dead Code

	afterCreatureZoneChange(creature, creature->getZones(), {});
	creature->onDeath();

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[dudantas]

It has been tested in production with 80 players in production, everything seems ok.