Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quests from version 12 revised #3042

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

htc16
Copy link
Contributor

@htc16 htc16 commented Oct 31, 2024

Description

I'm currently working on adding all quests to the PR. Given the large number of quests, I would like to ask for your help and collaboration to close this PR as quickly as possible. If you are interested in helping, choose one of the quests to review, open a PR for it, and link to this PR. All help is welcome!

Note1: my focus is on quests, therefore, the quest log for a quest may be missing as this is not shown in the quest tutorial lists. I study tutorials and release fix ones or develop something related to the tutorial.

Note2: I have limitations as this is the first time I am willing to do this, so please consider that some codes may not be the best but what matters is the intention and this can be improved in the future if someone finds it appropriate to do so.

Note3: I'm taking the opportunity to catalog all the aids and uids so that we can eventually modify and change them in the future directly through the script.

Note4: this PR needs some updates to the map that were reported above.

Note5: I was unable to place the writings in the books, only through the map editor, but this did not influence the development of the quest, so I left this for a future review.

Behavior

Real

I reviewed and corrected any quests that weren't working.

Delete options that are not relevant.

  • Bug fix (rolling change that fixes a problem)
  • New feature (rolling change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How this was tested

As I reviewed and modified the codes, I tested them.

Test Setup:

  • Server version: current
  • Client: 13
  • Operating system: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I performed a self-review of my own code
  • I checked the PR checks reports
  • I commented my code, especially in areas that were difficult to understand
  • I made corresponding changes to the documentation
  • My changes do not generate new warnings
  • I added tests that prove my fix is ​​effective or that my feature works

@htc16 htc16 marked this pull request as draft October 31, 2024 18:35
@htc16 htc16 closed this Nov 1, 2024
@majestyotbr majestyotbr changed the title Fix quests from version 12 revised fix: quests from version 12 revised Nov 1, 2024
@majestyotbr majestyotbr reopened this Nov 1, 2024
@htc16 htc16 force-pushed the fix-quests-from-version-12-revised branch from 55e173f to 276c406 Compare November 3, 2024 12:57
@htc16 htc16 marked this pull request as ready for review November 8, 2024 17:35
@htc16 htc16 mentioned this pull request Nov 18, 2024
5 tasks
@htc16 htc16 force-pushed the fix-quests-from-version-12-revised branch from 1a4617b to 04053f3 Compare November 19, 2024 22:49
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale No activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants