-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: remove unnecessary inheritance from lua interface classes #3046
Merged
dudantas
merged 11 commits into
main
from
dudantas/clean-code-from-lua-script-interface
Nov 10, 2024
Merged
cleanup: remove unnecessary inheritance from lua interface classes #3046
dudantas
merged 11 commits into
main
from
dudantas/clean-code-from-lua-script-interface
Nov 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
changed the title
cleanup: remove unecessary inheritance from lua interface classes
cleanup: remove unnecessary inheritance from lua interface classes
Nov 1, 2024
Fixed circular dependencies Removed various unecessary inheritance from lua interface Removed legacy unused codes
dudantas
force-pushed
the
dudantas/clean-code-from-lua-script-interface
branch
from
November 1, 2024 05:42
65a122e
to
1663a47
Compare
dudantas
force-pushed
the
dudantas/clean-code-from-lua-script-interface
branch
from
November 1, 2024 08:33
c1f98c5
to
4e98420
Compare
dudantas
force-pushed
the
dudantas/clean-code-from-lua-script-interface
branch
from
November 1, 2024 22:31
d236ea6
to
88964f2
Compare
dudantas
force-pushed
the
dudantas/clean-code-from-lua-script-interface
branch
from
November 9, 2024 23:14
f4312a0
to
27c9e73
Compare
dudantas
force-pushed
the
dudantas/clean-code-from-lua-script-interface
branch
from
November 9, 2024 23:15
3635921
to
beed45b
Compare
phacUFPE
approved these changes
Nov 10, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed circular dependencies
Removed various unnecessary inheritance from lua interface
Removed legacy unused codes