Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: review quests version 11 #3049

Merged
merged 80 commits into from
Nov 8, 2024
Merged

Conversation

Glatharth
Copy link
Contributor

@Glatharth Glatharth commented Nov 1, 2024

Description

Fixing the PR #2938 levers and related parts. Since the original code was quite extensive, perhaps some mechanics that should have been done when pulling the lever were removed.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integrity of the levers
  • Boss mechanics after lever is used

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

htc16 and others added 30 commits October 3, 2024 13:20
Before only a normal player could pull a lever and go to the boss room even though that wasn't the minimum requirement.
I'm testing more possibilities.
This is already set up.
@murilo09 murilo09 linked an issue Nov 3, 2024 that may be closed by this pull request
5 tasks
Copy link

sonarqubecloud bot commented Nov 8, 2024

@dudantas dudantas merged commit dd746c8 into opentibiabr:main Nov 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lib BossLever amount of players function
5 participants