Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent crash in condition light division #3053

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

kaleohanopahala
Copy link
Contributor

@kaleohanopahala kaleohanopahala commented Nov 2, 2024

Fix #3047

Now min light level is always 1.
Prevent division by zero.

Copy link

sonarqubecloud bot commented Nov 2, 2024

@kaleohanopahala kaleohanopahala changed the title Fix crash on condition light division Fix crash in condition light division Nov 2, 2024
@dudantas dudantas changed the title Fix crash in condition light division fix: prevent crash in condition light division Nov 2, 2024
@dudantas dudantas marked this pull request as draft November 2, 2024 16:34
@dudantas dudantas marked this pull request as ready for review November 2, 2024 18:19
@dudantas
Copy link
Member

dudantas commented Nov 2, 2024

Sorry, I added it as a draft by mistake.

Copy link
Contributor

@Zbizu Zbizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closes #3047

@dudantas dudantas merged commit b82568a into opentibiabr:main Nov 3, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible crash: CONDITION_LIGHT division by zero
6 participants