Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: speed and conditions #3063

Merged
merged 3 commits into from
Nov 10, 2024
Merged

fix: speed and conditions #3063

merged 3 commits into from
Nov 10, 2024

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Nov 5, 2024

Description

This fixes the high speed bug that overflow the uint16_t because the lack of checks and also fixes the conditions mysql issue when saving conditions greater than 64KB.

Behaviour

Actual

The player speed can be less than its basespeed causing uint16_t overflow and bugging the speed.
The conditions when saving that is greather than 64KB could not be saved due to the table column blob type limitation.

Expected

The player speed can not be less than its basespeed that was causing uint16_t overflow and not bugging the speed.
The conditions when saving that is greather than 16MB can be saved.

Fixes #2712

Fixes #2456

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Create and apply a condition that reduces the player speed to less than its base speed

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

sonarqubecloud bot commented Nov 6, 2024

@dudantas dudantas merged commit ed759b0 into main Nov 10, 2024
45 checks passed
@dudantas dudantas deleted the phacUFPE/fix_speed_and_conditions branch November 10, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hight Speed in paladin wheel of destiny (Royal Paladin )
4 participants