fix: remove empty if block and prevent use of pointer after erase

[dudantas]

Description

This PR removes an empty if block that was originally used back when pointer management was manual using raw pointers (*). At that time, the if block was intended to decrement the reference counter in a manual garbage collection mechanism. Since the project now uses modern smart pointers, this block has become obsolete and can be safely removed without affecting functionality.

The change also prevents the use of the container pointer after erasing the iterator it from the openContainers map, which was causing undefined behavior and potential crashes.

Behaviour

Actual

When attempting to close a container, the program would access a pointer (container) after its related iterator had been erased, resulting in a crash.

Expected

When closing a container, the program should remove the container entry safely without attempting to access invalidated pointers, preventing crashes.

Fixes this crash: crash.txt

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Manual testing to verify container closing works as expected without accessing invalid pointers.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud