Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: combat type out of index in ashes item #3106

Merged
merged 1 commit into from
Nov 12, 2024

fix: combat type out of index in ashes item

6fb80c8
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: combat type out of index in ashes item #3106

fix: combat type out of index in ashes item
6fb80c8
Select commit
Loading
Failed to load commit list.
GitHub Actions / shellcheck succeeded Nov 12, 2024 in 0s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (3)

start_gdb.sh|18 col 6| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
recompile.sh|65 col 30| To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).
docker/config.sh|13 col 11| Use grep -q instead of comparing output with [ -n .. ].

View more details on GitHub Actions