Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: simplify some account functions and fix console error #3110

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

omarcopires
Copy link
Contributor

Description

Removes a duplicate function.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@dudantas dudantas changed the title feat: add Game.getPlayerAccountId with compatibility for getAccountNu… cleanup: simplify some account functions and console error Nov 13, 2024
@dudantas dudantas changed the title cleanup: simplify some account functions and console error cleanup: simplify some account functions and fix console error Nov 13, 2024
@dudantas dudantas merged commit 73f5c5a into opentibiabr:main Nov 13, 2024
18 checks passed
@omarcopires omarcopires deleted the duplicated-function branch November 13, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants