Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wheel spells bonuses #3122

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: wheel spells bonuses #3122

merged 1 commit into from
Nov 18, 2024

Conversation

phacUFPE
Copy link
Contributor

Description

This fixes the issue that some spells was sharing bonuses between all other spells

Behaviour

Actual

All spells sharing the same bonuses

Expected

All spells are not sharing the same bonuses

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Log in on a Paladin and add the max points to the first Divine Caldera spell
  • Say the spell and it shouldn't be the cooldown reduced

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

sonarqubecloud bot commented Nov 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dudantas dudantas merged commit ba6ad33 into main Nov 18, 2024
35 checks passed
@dudantas dudantas deleted the phacUFPE/fix_wheel_spells branch November 18, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants