Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialize totalCost correctly and refactor blessing purchase logic #3142

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

omarcopires
Copy link
Contributor

Description

This PR fixes the initialization of the totalCost variable and refactors the blessing purchase logic. Improvements include replacing string concatenation with string.format for more efficient formatting, as well as adjustments for better code clarity and readability. The code is now more organized, and the calculation error has been fixed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@dudantas dudantas merged commit ed8abb6 into opentibiabr:main Nov 21, 2024
18 checks passed
@omarcopires omarcopires deleted the fix-buy-blessings branch November 21, 2024 18:17
@dudantas dudantas linked an issue Nov 21, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After commit #3064 !bless talkaction no longer works
2 participants