Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker gha build workflow #3167

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix: docker gha build workflow #3167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfd28fa
fix: docker build
dudantas Dec 3, 2024
dc01607
test: docker create cache
dudantas Dec 3, 2024
4b69dd3
Merge branch 'main' into dudantas/fix-docker-build
dudantas Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/workflows/build-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,20 +43,12 @@
uses: gittools/actions/gitversion/[email protected]

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

Check failure on line 46 in .github/workflows/build-docker.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build-docker.yml#L46 

the runner of "docker/setup-buildx-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
Raw output 
.github/workflows/build-docker.yml:46:15: the runner of "docker/setup-buildx-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
with:
install: true

- name: Cache Docker layers
uses: actions/cache@main
with:
path: /tmp/.buildx-cache
key: ${{ runner.os }}-x86-${{ github.sha }}
restore-keys: |
${{ runner.os }}-x86-

- name: Login to GitHub Container Registry
uses: docker/login-action@v2

Check failure on line 51 in .github/workflows/build-docker.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build-docker.yml#L51 

the runner of "docker/login-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
Raw output 
.github/workflows/build-docker.yml:51:15: the runner of "docker/login-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
Expand Down Expand Up @@ -105,18 +97,10 @@
uses: gittools/actions/gitversion/[email protected]

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

Check failure on line 100 in .github/workflows/build-docker.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build-docker.yml#L100 

the runner of "docker/setup-buildx-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
Raw output 
.github/workflows/build-docker.yml:100:15: the runner of "docker/setup-buildx-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
with:
install: true

- name: Cache Docker layers
uses: actions/cache@main
with:
path: /tmp/.buildx-cache
key: ${{ runner.os }}-arm-${{ github.sha }}
restore-keys: |
${{ runner.os }}-arm-

- name: Build
uses: docker/[email protected]
with:
Expand Down
4 changes: 2 additions & 2 deletions docker/Dockerfile.arm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Stage 1: Download all dependencies
FROM ubuntu:23.04 AS dependencies
FROM ubuntu:24.04 AS dependencies

RUN apt-get update && apt-get install -y --no-install-recommends cmake git \
unzip build-essential ca-certificates curl zip unzip tar \
Expand Down Expand Up @@ -30,7 +30,7 @@ WORKDIR /srv
RUN export VCPKG_ROOT=/opt/vcpkg/ && VCPKG_FORCE_SYSTEM_BINARIES=1 cmake --preset linux-release && cmake --build --preset linux-release

# Stage 3: load data and execute
FROM ubuntu:23.04
FROM ubuntu:24.04

VOLUME [ "/data" ]

Expand Down
4 changes: 2 additions & 2 deletions docker/Dockerfile.x86
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Stage 1: Download all dependencies
FROM ubuntu:23.04 AS dependencies
FROM ubuntu:24.04 AS dependencies

RUN apt-get update && apt-get install -y --no-install-recommends cmake git \
unzip build-essential ca-certificates curl zip unzip tar \
Expand Down Expand Up @@ -30,7 +30,7 @@ WORKDIR /srv
RUN export VCPKG_ROOT=/opt/vcpkg/ && cmake --preset linux-release && cmake --build --preset linux-release

# Stage 3: load data and execute
FROM ubuntu:23.04
FROM ubuntu:24.04
VOLUME [ "/data" ]

COPY --from=build /srv/build/linux-release/bin/canary /bin/canary
Expand Down
Loading