Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: position after try to cross bridge #3175

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

pess0a
Copy link
Contributor

@pess0a pess0a commented Dec 13, 2024

Description

The problem was that the ladder action was executed first, followed immediately by the teleportTo action, causing the Player to move above the ladder with the possibility of crossing the bridge.

Behaviour

Actual

before

Expected

after

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version: canary from main
  • Client: 13.40
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@murilo09 murilo09 changed the title Fix position after try to cross bridge fix: position after try to cross bridge Dec 13, 2024
@dudantas dudantas merged commit 03f1d14 into opentibiabr:main Dec 14, 2024
19 checks passed
vasconcellosdevictor pushed a commit to vasconcellosdevictor/canary that referenced this pull request Dec 15, 2024
The problem was that the ladder action was executed first, followed
immediately by the teleportTo action, causing the Player to move above
the ladder with the possibility of crossing the bridge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants