fix: infinite loop in Zone:randomPosition when no valid tile exist

[dudantas]

Description

This commit fixes an infinite loop issue in the Zone:randomPosition function. When no valid positions (walkable tiles) exist in the zone, the function would previously enter an infinite loop. The updated logic now filters all positions upfront to identify walkable tiles, and if none are found, the function returns nil with appropriate logging. This change ensures better error handling and prevents server freezes due to infinite loops.

Behaviour

Actual

Calling Zone:randomPosition on a zone with no valid walkable positions causes an infinite loop, leading to a server hang.

Expected

Calling Zone:randomPosition on a zone with no valid walkable positions returns nil without entering an infinite loop, and logs the issue for debugging.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

The changes were tested by creating zones with:

1. No positions.
2. Positions that are not walkable.
3. A mix of walkable and non-walkable positions.

Test cases:

• Zone with no positions returns nil and logs an error.
• Zone with no walkable positions returns nil and logs an error.
• Zone with valid walkable positions returns a random valid position.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud