fix: wrong calculation from elemental damage for weapons

[dudantas]

Description

This PR fixes an issue with the calculation of elemental weapon damage. Previously, the damage calculation for elemental weapons duplicated the damage instead of distributing it as 60% elemental and 40% physical (or vice-versa). This resulted in incorrect damage values and an overpowered effect for certain weapons.

The corrected logic ensures that the total damage remains consistent, splitting appropriately based on the elemental and physical proportions while applying target resistances/weaknesses correctly.

Behaviour

Actual

Using elemental weapons caused the damage calculation to incorrectly duplicate the total damage, leading to inflated results that did not respect the intended 60/40% distribution.

Expected

Using elemental weapons distributes the total damage correctly as 60% elemental and 40% physical, with adjustments for the target's resistances or weaknesses to the specific element.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

The fix has been tested thoroughly to verify the proper distribution of elemental and physical damage. Test cases include:

• Attacking monsters with elemental weaknesses.
• Attacking monsters with elemental resistances.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

Font: https://forum.portaltibia.com.br/topic/36599-armas-dano-elemental/

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud